fix: remove redundant type assertion in EditProgramPage#3653
Closed
Adarshkumar0509 wants to merge 3 commits intoOWASP:mainfrom
Closed
fix: remove redundant type assertion in EditProgramPage#3653Adarshkumar0509 wants to merge 3 commits intoOWASP:mainfrom
Adarshkumar0509 wants to merge 3 commits intoOWASP:mainfrom
Conversation
Remove the unnecessary (session as ExtendedSession) cast as it does not change the type, addressing SonarQube rule typescript:S4325. The type assertion was redundant because the compiler already infers the session type correctly in this context.
Contributor
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughRemoved a duplicate Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@frontend/src/app/my/mentorship/programs/`[programKey]/edit/page.tsx:
- Around line 56-58: Add a type-safe cast for session when accessing user.login:
import the ExtendedSession type (import type { ExtendedSession } from
'types/auth') and update the isAdmin check in the isAdmin computation (the
expression using data.getProgram.admins and session) to compare admin.login
against (session as ExtendedSession)?.user?.login so the login property access
is type-safe and matches the pattern used elsewhere.
frontend/src/app/my/mentorship/programs/[programKey]/edit/page.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Changes requested by CodeRabbit have been applied; ready for another look. |
|
kasya
reviewed
Feb 3, 2026
Comment on lines
+56
to
+58
| const isAdmin = data.getProgram.admins?.some( | ||
| (admin: { login: string }) => admin.login === (session as ExtendedSession)?.user?.login | ||
| ) |
Collaborator
There was a problem hiding this comment.
Why did you change indentation here? And I believe the assertion (the issue you needed to fix) is still there 👀
Collaborator
|
Closing this in favor of #3628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the SonarQube code smell (typescript:S4325) by removing a redundant type assertion in the EditProgramPage component.
Changes
(session as ExtendedSession)cast infrontend/src/app/my/mentorship/programs/[programKey]/edit/page.tsxExtendedSessionimportTesting
Issue
Fixes SonarQube rule typescript:S4325: Redundant casts and non-null assertions should be avoided
This improves code maintainability by removing unnecessary type assertions.
Resolves #3554